Repository navigation
[Server] Answer an unknown method with -32601 on the handshake era - #737
Open
skybleak333 wants to merge 1 commit into
Open
skybleak333 wants to merge 1 commit into
skybleak333 wants to merge 1 commit into
Conversation
skybleak333
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 11, 2026 13:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handshake-era request for a method the SDK does not know, e.g.
{"jsonrpc":"2.0","id":7,"method":"nonexistent/method"}, is answered with-32600, while JSON-RPC and the2026-07-28era (since #681) use-32601.Protocol::handleInvalidMessage()now mapsUnknownMethodExceptionto-32601;server/discoversent over a handshake connection gets-32601too, which the client already treats as a legacy server.Found, fixed and written up with Claude Code.